Move evolution strategy bounds to init #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
btjanaka
added a commit
that referenced
this pull request
Dec 9, 2023
## Description <!-- Provide a brief description of the PR's purpose here. --> This PR adds the `ranking_values` argument to the tell() method in evolution strategies. This paves the way for #434, since pycma needs the ranking values to be passed into tell(). Note that I considered removing ranking_values from `check_stop` and instead forcing the ES to store its own ranking values like pycma does, but I do not think this is a necessary change. This change is backwards-incompatible, but similar to #436, I do not think it will affect most users. ## TODO <!-- Notable points that this PR has either accomplished or will accomplish. --> - [x] Update EvolutionStrategyBase and corresponding ESs - [x] Update emitter calls - [x] Remove redundant method docstrings ## Questions <!-- Any concerns or points of confusion? --> ## Status - [x] I have read the guidelines in [CONTRIBUTING.md](https://github.com/icaros-usc/pyribs/blob/master/CONTRIBUTING.md) - [x] I have formatted my code using `yapf` - [x] I have tested my code by running `pytest` - [x] I have linted my code with `pylint` - [x] I have added a one-line description of my change to the changelog in `HISTORY.md` - [x] This PR is ready to go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, bounds were passed in to the ES's in the
askmethod. However, we never use dynamic bounds, so it makes more sense to simply pass in the bounds in the init, as is done in the emitters.Also made some other small changes to clean up the ESs (see TODO list below).
While moving the bounds around is a backwards-incompatible change, I do not anticipate this will affect many people since the evolution strategies are mostly internal classes that are called by the emitters.
TODO
lower_boundsandupper_boundstoEvolutionStrategyBase.__init__lower_boundsandupper_boundsfromEvolutionStrategyBase.ask()batch_size=NonetoEvolutionStrategyBase.ask()(currently, all ES's do this but it was not reflected in the base class).EvolutionStrategyBasethreadpool_limitsin sep-CMA-ES, LM-MA-ES, and OpenAI-ES -- threadpool_limits was only intended to help with eigendecompositions, and these classes do not use eigendecompositionsQuestions
Status
CONTRIBUTING.md
yapfpytestpylintHISTORY.md